Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @mmcky, I think the connection issue comes up again from the Anaconda side: |
|
thanks @HumphreyYang -- just triggered a rebuild. |
|
Many thanks @SylviaZhaooo . Does this pull request address a particular issue? (If yes, then you can put "Fixes #XXX", where XXX is the issue number, and the issue will be closed automatically when this PR is merged.) Does the reader have enough information to complete the exercise? For example, do they need to know parameter values? @shlff , could you please review this carefully and work with @SylviaZhaooo to finish it? If I look at https://669dffc4710cf5c7cb257aa4--taupe-gaufre-c4e660.netlify.app/geom_series, it seems that a lot of extra content is included in the solution --- "We now examine what will happen..." |
|
Thanks @SylviaZhaooo and @jstac . Hi @SylviaZhaooo I had a look at this PR, and I suggest we break this section into 2 or more exercises
After breaking it down, we then polish the exercise titles and solutions one by one. |
mmcky
left a comment
There was a problem hiding this comment.
thanks @shlff and @SylviaZhaooo for this PR. Just a couple of final questions to go.
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
|
Hi @mmcky, I think these are |
|
Thanks @SylviaZhaooo and @mmcky . Hi @SylviaZhaooo , I had a look at the code and I suggested the following modifications to improve the clarity. You can vote if we should adopt these. |
Co-authored-by: Shu Hu <shu.hu@anu.edu.au>
Co-authored-by: Shu Hu <shu.hu@anu.edu.au>
Co-authored-by: Shu Hu <shu.hu@anu.edu.au>
Co-authored-by: Shu Hu <shu.hu@anu.edu.au>
|
Hi @shlff, Thanks for your suggestions! I've reviewed your modifications and committed all the changes. Let me know if there’s anything else you’d like me to adjust or if further improvements are needed. |
|
Thanks @SylviaZhaooo . It looks better to me now. If you are happy with it, then we could hand it over to @mmcky for a final review. Hi @mmcky here is a link to the most recent preview: https://670a4ceac856cc023983ef0f--taupe-gaufre-c4e660.netlify.app/geom_series |
|
thanks @shlff and @SylviaZhaooo -- I think this is looking good. 👍 |
|
@jstac this is ready for final review and merge. |
Dear John @jstac,
Same as before, I changed the last part, the Keynesian model with plots and code snippets part, into an exercise since the logic of this model has been illustrated so it is easy to have the same model as an exercise.
Fixes #401
Best,
Sylvia